-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[breaking] gRPC UpdateIndex
and UpdateLibrariesIndex
improvements
#2569
Conversation
The two calls now have the update_if_older_than_secs field that allows to avoid updating the index if it has been already updated. Also the response is more explicit with oneof(..) clause and the status of each update (in case of multiple index update) is returned in the response.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2569 +/- ##
==========================================
+ Coverage 69.48% 69.58% +0.09%
==========================================
Files 205 205
Lines 20204 20267 +63
==========================================
+ Hits 14038 14102 +64
- Misses 5045 5049 +4
+ Partials 1121 1116 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, in the future we could expand the daemon and cli --json tests, checking that IndexUpdateReport
contains what we'd expect.
Related to #2565 |
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.md
has been updated with a migration guide (for breaking changes)configuration.schema.json
updated if new parameters are added.What kind of change does this PR introduce?
UpdateIndex
andUpdateLibrariesIndex
now have theupdate_if_older_than_secs
field that prevents updating the index if it has already been updated. Also, the response is more explicit withoneof(..)
clause, and the status of each update (in case of multiple index updates) is returned in the response.The JSON output has been implemented for commands
core update-index
andlib update-index
.What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change, and is titled accordingly?
Yes
Other information