Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip-changelog] bump golangci-lint to v1.57.x #2571

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented Mar 25, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Bump golangci-lint to v1.57.x, and disable autofix

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@alessio-perugini alessio-perugini self-assigned this Mar 25, 2024
@alessio-perugini alessio-perugini added the topic: code Related to content of the project itself label Mar 25, 2024
@cmaglie cmaglie added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Mar 25, 2024
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 69.58%. Comparing base (6faca0f) to head (829f6fd).

Files Patch % Lines
commands/instances.go 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2571   +/-   ##
=======================================
  Coverage   69.58%   69.58%           
=======================================
  Files         205      205           
  Lines       20267    20267           
=======================================
  Hits        14102    14102           
  Misses       5049     5049           
  Partials     1116     1116           
Flag Coverage Δ
unit 69.58% <70.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessio-perugini alessio-perugini merged commit 32d8833 into master Mar 25, 2024
228 checks passed
@alessio-perugini alessio-perugini deleted the bump-golang-ci-lint branch March 25, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants