remove pkgs.html because of dangerous eval #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvanocerza
approved these changes
Oct 18, 2021
umbynos
added a commit
that referenced
this pull request
Dec 13, 2021
per1234
added
topic: security
umbynos
added a commit
that referenced
this pull request
Aug 25, 2023
a lot of docs file were deleted because in #670 I forgot to run generate Same
umbynos
added a commit
that referenced
this pull request
Aug 25, 2023
followup of #670 since generated doc files are not there anymore
umbynos
added a commit
that referenced
this pull request
Aug 25, 2023
a lot of docs file were deleted because in #670 I forgot to run generate Same
umbynos
added a commit
that referenced
this pull request
Aug 25, 2023
followup of #670 since generated doc files are not there anymore
umbynos
added a commit
that referenced
this pull request
Aug 28, 2023
a lot of docs file were deleted because in #670 I forgot to run generate Same
umbynos
added a commit
that referenced
this pull request
Aug 28, 2023
followup of #670 since generated doc files are not there anymore
umbynos
added a commit
that referenced
this pull request
Aug 28, 2023
* go get goa v3 & go mod tidy * bump goa version used in design files (DSL) * goa gen github.com/arduino/arduino-create-agent/design a lot of docs file were deleted because in #670 I forgot to run generate Same * remove doc server followup of #670 since generated doc files are not there anymore * go mod tidy again * bump to goa v3 also in v2 package * fixes after bump to goa v3 (needs to be tested) * update license cache * apply suggestions by code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
deprecate
pkgs.html could contain a potential security issue ( the use of eval).
This file apparently was intended only for development purposes and actually is not bundled in the build (with the distributed version of the agent going to http://127.0.0.1:8991/v2/docs/pkgs causes a 404). This is why it does not work in the stable version of the agent, and it’s not included in the build.
Furthermore, this file does not work as intended:
The DOM is not refreshed when a text is inserted in the textarea. This behavior makes this file completely useless and thus we should remove it.
remove that file
technically no, since this file is not included in the final build