-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The CI is now able to produce valid macOS Ventura bundles #740
Conversation
This can be tested here https://github.com/arduino/arduino-create-agent/releases/tag/1.2.7-ventura |
Codecov ReportBase: 8.45% // Head: 8.45% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
=====================================
Coverage 8.45% 8.45%
=====================================
Files 64 64
Lines 5052 5052
=====================================
Hits 427 427
Misses 4571 4571
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This way we can notarize all the bundle and not only the binary.
…the installer config
…) to use deep notarization, since this is not yet merged mitchellh/gon#42
7eedf9c
to
545ae5a
Compare
Please check if the PR fulfills these requirements
before creating one)
- [ ] Tests for the changes have been added (for bug fixes / features)CI fix
The bundles generated by the CI are not valid on macOS Ventura
The bundles are valid:
set-output commands
nope