-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove installbuilder from macos release artifact #785
Conversation
127e4f1
to
2b398a5
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #785 +/- ##
==========================================
- Coverage 11.29% 11.02% -0.28%
==========================================
Files 54 55 +1
Lines 3948 4046 +98
==========================================
Hits 446 446
- Misses 3447 3545 +98
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
3b7297a
to
d4c8b87
Compare
Ta daaaah! |
It seems to work fine on vanilla systems, but there are problems if there is an existing installation: previously the Agent was installed in
Two possible solutions for these problems:
|
I will target this suggestion in this PR since it's something installbuilder related Regarding the second point I created #788 to track the imperfection |
1afa34b
to
9b78c5c
Compare
Gon is able to produce a working dmg, but there is not a link to application and a background img, for that we need `create-dmg` This reverts commit 7bb8b91.
This reverts commit e7c1b1d.
This reverts commit c528951af94dab326e01331e87745e46ea093c4f.
otherwise we break the agent after the auto-update
e82db34
to
fc49266
Compare
Please check if the PR fulfills these requirements
before creating one)
change how the installer is generated
Fix #739: Currently, the installer for all the platform is generated using installbuilder.
There is an easier way of doing it: Distributing a DMG, which should be only be presented as a window with the ArduinoCreateAgent app to be draggable inside the Application folder.
yes, the user before the update process has to manually uninstall the old version of the agent (version <= 1.2.7-ventura). From 1.2.8 onward, the update process should overwrite
/Applications/ArduinoCreateAgent