Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the autostart file when it's required #791

Merged
merged 2 commits into from
May 23, 2023
Merged

Update the autostart file when it's required #791

merged 2 commits into from
May 23, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented May 19, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

fix corner case introduced in #781

  • What is the current behavior?

Fix #788, the agent is now able to detect if the autostart file needs to be overwritten or not

  • What is the new behavior?

The agent is now able to update the autostart file when it's required.

  • Does this PR introduce a breaking change?

no

  • Other information:

@umbynos umbynos added type: enhancement Proposed improvement topic: code Related to content of the project itself os: macos Specific to macOS operating system labels May 19, 2023
@umbynos umbynos requested a review from cmaglie May 19, 2023 16:16
@umbynos umbynos self-assigned this May 19, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (4e7b23f) 11.00% compared to head (038acf6) 10.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   11.00%   10.96%   -0.05%     
==========================================
  Files          55       55              
  Lines        4052     4069      +17     
==========================================
  Hits          446      446              
- Misses       3551     3568      +17     
  Partials       55       55              
Flag Coverage Δ
unit 10.96% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
config/autostart.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@umbynos
Copy link
Contributor Author

umbynos commented May 22, 2023

config/autostart.go Outdated Show resolved Hide resolved
Otherwise the agent is not started at all
@umbynos umbynos merged commit c9c688d into main May 23, 2023
@umbynos umbynos deleted the plist-update branch May 23, 2023 15:47
@umbynos umbynos added this to the MacOS Ventura Support milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: macos Specific to macOS operating system topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the autostart file when required
3 participants