-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace deprecated openpgp library #839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
Proposed improvement
topic: security
Related to the protection of user data
topic: infrastructure
Related to project infrastructure
labels
Sep 27, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## remove-indexes-v2-endpoint #839 +/- ##
===========================================================
Coverage 18.90% 18.90%
===========================================================
Files 46 46
Lines 3624 3624
===========================================================
Hits 685 685
Misses 2849 2849
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
alessio-perugini
approved these changes
Sep 27, 2023
rhpco
approved these changes
Sep 27, 2023
2 tasks
umbynos
force-pushed
the
remove-indexes-v2-endpoint
branch
2 times, most recently
from
September 29, 2023 16:11
4f358e4
to
252a80f
Compare
umbynos
force-pushed
the
replace-openpgp-lib
branch
from
September 29, 2023 16:41
dba6b88
to
f17b83d
Compare
umbynos
force-pushed
the
remove-indexes-v2-endpoint
branch
from
September 29, 2023 17:20
252a80f
to
3f05681
Compare
umbynos
force-pushed
the
replace-openpgp-lib
branch
from
September 29, 2023 17:25
f17b83d
to
a4c86c4
Compare
umbynos
force-pushed
the
remove-indexes-v2-endpoint
branch
from
October 6, 2023 15:24
3f05681
to
5f0a64c
Compare
umbynos
force-pushed
the
replace-openpgp-lib
branch
from
October 9, 2023 13:15
a4c86c4
to
5f46289
Compare
umbynos
force-pushed
the
replace-openpgp-lib
branch
from
October 9, 2023 13:17
5f46289
to
9b3be7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: infrastructure
Related to project infrastructure
topic: security
Related to the protection of user data
type: enhancement
Proposed improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Dependency replace
The openpgp library we were using has been marked as deprecated (see golang/go#44226)
Replace it with a maintaned one
no
Similar to arduino/arduino-cli#2333
Has to be rebased on main after #838 is merged