Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated openpgp library #839

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Replace deprecated openpgp library #839

merged 2 commits into from
Oct 9, 2023

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented Sep 27, 2023

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Dependency replace

  • What is the current behavior?

The openpgp library we were using has been marked as deprecated (see golang/go#44226)

  • What is the new behavior?

Replace it with a maintaned one

  • Does this PR introduce a breaking change?

no

  • Other information:

Similar to arduino/arduino-cli#2333
Has to be rebased on main after #838 is merged

@umbynos umbynos added type: enhancement Proposed improvement topic: security Related to the protection of user data topic: infrastructure Related to project infrastructure labels Sep 27, 2023
@umbynos umbynos self-assigned this Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (3f05681) 18.90% compared to head (a4c86c4) 18.90%.

Additional details and impacted files
@@                     Coverage Diff                     @@
##           remove-indexes-v2-endpoint     #839   +/-   ##
===========================================================
  Coverage                       18.90%   18.90%           
===========================================================
  Files                              46       46           
  Lines                            3624     3624           
===========================================================
  Hits                              685      685           
  Misses                           2849     2849           
  Partials                           90       90           
Flag Coverage Δ
unit 18.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
index/index.go 52.50% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@umbynos umbynos force-pushed the remove-indexes-v2-endpoint branch 2 times, most recently from 4f358e4 to 252a80f Compare September 29, 2023 16:11
Base automatically changed from remove-indexes-v2-endpoint to main October 9, 2023 13:13
@umbynos umbynos merged commit 4263eb5 into main Oct 9, 2023
45 checks passed
@umbynos umbynos deleted the replace-openpgp-lib branch October 9, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure topic: security Related to the protection of user data type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants