fix agent being built for 32 bit linux for real #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
os: linux
umbynos
force-pushed
the
fix-32-bit-linux
branch
from
11fc573
to
64b8073
Compare
alessio-perugini
approved these changes
Oct 25, 2023
umbynos
commented
Nov 7, 2023
| @@ -394,7 +394,11 @@ jobs: | |||
| # installbuilder reads the env vars with certs paths and use it to sign the installer. | |||
| - name: Launch Bitrock installbuilder | |||
| run: | | |||
| ${{ env.INSTALLBUILDER_PATH }} build installer.xml ${{ matrix.platform-name }} --verbose --license /tmp/license.xml --setvars ${{ env.INSTALLER_VARS }} architecture=${{ matrix.arch }} | |||
| if [[ ${{matrix.platform-name}} == "linux" ]]; then | |||
There was a problem hiding this comment.
Actually this condition is wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
bugfix 🐞
The agent builds after 1.2.7 on linux have different kind of problems:
1.3.0,1.3.1,1.3.2are being built for linux 32 bit (see Agent installer built for linux 32-bit after version 1.2.7 #803)1.3.3does not contain the agent binaries (see Create Agent v1.3.3 Linux installers do not contain Arduino_Create_Agent executable #846)I thought to have fixed #803, in the installer repo, but the regression comes from this change (note the argument to
installbuilderhas been changed fromlinux-x64tolinux).This PR will
no