Replace mitchellh/go used for macOS notarization #851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbynos
added
type: enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
=======================================
Coverage 19.62% 19.62%
=======================================
Files 46 46
Lines 3685 3685
=======================================
Hits 723 723
Misses 2868 2868
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
umbynos
force-pushed
the
gon-bye
branch
4 times, most recently
from
adef020
to
79d6ae7
Compare
I split the singing/notarization because Bearer fork does not implement `--deep` for signing
MatteoPologruto
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
change in tooling see arduino/tooling-project-assets#359
An excellent tool named gon was used to perform the notarization.
the latest stable release of gon uses the altool command-line utility for notarization:
https://github.com/mitchellh/gon/blob/v0.2.5/notarize/upload.go#L41
Using altool for notarization is now deprecated by Apple and support for notarization via this tool is scheduled to be disabled 2023-11-01:
https://developer.apple.com/news/?id=y5mjxqmn
Furthermore, gon was archived
I switched to https://github.com/Bearer/gon that has included mitchellh/gon#72, hoping the maintainers will take the responsibility of maintaining the project.
I added also AC_PROVIDER env var which is mandatory with the new notarytool.
no
I split the signing/notarization of the bundle, because the Bearer fork does not include support for
--deepsigning.Test release here:
Uploading ArduinoCreateAgent-1.3.4-rc2-osx-amd64-installer.zip…