Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore functionality of 'is_open' field in portlist #939

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Apr 16, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?
    Restore functionality of 'is_open' field in portlist
  • What is the current behavior?
    is_open is always false
  • What is the new behavior?
    is_open is true while the port is open for monitoring
  • Does this PR introduce a breaking change?
    No
  • Other information:

@cmaglie cmaglie self-assigned this Apr 16, 2024
@cmaglie cmaglie linked an issue Apr 16, 2024 that may be closed by this pull request
3 tasks
@cmaglie cmaglie added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 16, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 21.43%. Comparing base (8e28a0c) to head (ff59a8b).

Files Patch % Lines
serial.go 0.00% 17 Missing ⚠️
serialport.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #939      +/-   ##
==========================================
- Coverage   21.60%   21.43%   -0.18%     
==========================================
  Files          42       42              
  Lines        2495     2515      +20     
==========================================
  Hits          539      539              
- Misses       1859     1879      +20     
  Partials       97       97              
Flag Coverage Δ
unit 21.43% <0.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on linux ✔️

@cmaglie cmaglie merged commit c42fcd7 into main Apr 16, 2024
42 checks passed
@cmaglie cmaglie deleted the is_open_signal branch April 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent does not properly update 'IsOpen' Port State
3 participants