Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the "Debug Console" to add functionality and fix bugs #944

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Improve the "Debug Console" to add functionality and fix bugs #944

merged 2 commits into from
Apr 30, 2024

Conversation

Xayton
Copy link
Contributor

@Xayton Xayton commented Apr 29, 2024

Changes:

  • Improved the CSS code and JS code
  • Added the support for the "show 'list'" options as a select
  • Add an additional section to show only the "list" commands, when the user selects such option
  • Fixed the code detecting "list" messages, as it was missing cases where the JSON content had a "Ports" property but its value was null instead of an empty array.

Closes #943

@Xayton
Update the home.html file that powers the "Debug Console":
3729bb1 
- Improved the CSS code and JS code
- Added the support for the "show 'list'" options as a select
- Add an additional section to show only the "list" commands, when the user selects such option
- Fixed the code detecting "list" messages, as it was missing cases where the JSON content had a "Ports" property but its value was null instead of an empty array.
alessio-perugini
alessio-perugini approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super 🚀

I see that we're using a very old version of jquery, what do you think if we remove it and use just vanilla js?

umbynos
umbynos reviewed Apr 30, 2024
View reviewed changes
home.html Outdated
const MESSAGES_MAX_COUNT = 2000;

// Check if the list visibility setting is saved in the localStorage.
const LOCAL_STORAGE_KEY = "ArduinoAgentListVisibility";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 noice!

umbynos
umbynos approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work!

@Xayton
The Debug Console is now jQuery-free.
2b3e8ae 
The code has been restructured to be simpler and avoid global variable as much as possible.
@Xayton
Copy link
Contributor Author

Xayton commented Apr 30, 2024 •
edited
Loading

@alessio-perugini @umbynos jQuery has been removed, code simplified a bit and global variables usage reduced.
Can be easily tested by building the agent locally.

alessio-perugini
alessio-perugini approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 🤩 .
Tested on ubuntu working 🚀

@Xayton Xayton merged commit d9135cd into main Apr 30, 2024
4 checks passed
@Xayton Xayton deleted the improve-debug-console branch April 30, 2024 14:47
@per1234 per1234 added type: enhancement Proposed improvement topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alessio-perugini alessio-perugini alessio-perugini approved these changes

@umbynos umbynos umbynos approved these changes

@cmaglie cmaglie Awaiting requested review from cmaglie

@MatteoPologruto MatteoPologruto Awaiting requested review from MatteoPologruto

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the "Debug Console" page
4 participants
@Xayton @alessio-perugini @umbynos @per1234