Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert lock while reading from the installed map #987

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Aug 5, 2024

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce?

Code enhancement

  • What is the new behavior?

Insert lock while reading from the installed map to prevent concurrent access.

  • Does this PR introduce a breaking change?

No

  • Other information:

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Aug 5, 2024
@MatteoPologruto MatteoPologruto self-assigned this Aug 5, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.85%. Comparing base (a945e56) to head (254654f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #987      +/-   ##
==========================================
+ Coverage   20.70%   20.85%   +0.15%     
==========================================
  Files          42       42              
  Lines        2565     2570       +5     
==========================================
+ Hits          531      536       +5     
  Misses       1949     1949              
  Partials       85       85              
Flag Coverage Δ
unit 20.85% <100.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MatteoPologruto MatteoPologruto merged commit fb06ef3 into arduino:main Aug 5, 2024
20 checks passed
@MatteoPologruto MatteoPologruto deleted the read-lock branch August 5, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants