Add support for macos arm64 build #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add macos arm64 - differentiate linux arm into linux armv6, and linux armv7
umbynos
added
type: enhancement
per1234
requested changes
Jul 1, 2022
| # See: https://github.com/actions/setup-go/tree/v2#readme | ||
| GO_VERSION: ^1.16.2 | ||
| # See: https://github.com/actions/setup-go/tree/main#supported-version-syntax | ||
| GO_VERSION: "1.17" |
There was a problem hiding this comment.
I think this change should be made universally throughout the project infrastructure:
Line 3 in 96b4a40
There was a problem hiding this comment.
should we do it in another PR?
There was a problem hiding this comment.
I think that is a good idea, since it is a significant change not directly related to the purpose of this PR. If you do that, I would recommend leaving this workflow and .github/workflows/publish-go-tester-task.yml at their previous Go ^1.16.2 version since I don't think it is beneficial to introduce even greater inconsistency in the versions used throughout the project's infrastructure.
- add macos arm64 - differentiate linux arm into linux armv6, and linux armv7 - bump version of GO to 1.17 - bump upload/artifact action from 2 to 3 - add checksum upload - remove unnecessary line continuation escaping from workflow
- add macos arm64 - differentiate linux arm into linux armv6, and linux armv7 - bump version of GO to 1.17 - bump upload/artifact action from 2 to 3 - add checksum upload - remove unnecessary line continuation escaping from workflow - rename workflow - remove `gon.config.hcl` since now is hardcoded in the workflow
This reverts commit 5ddd847.
per1234
approved these changes
Jul 4, 2022
4 tasks
This was referenced Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only macOS build of the application was for x86-64 host architecture.
That build was also compatible for use on Apple M1 based machines via Rosetta 2 translation. However, a native ARM 64-bit build is optimum for use on these machines.
This brings the standardized build assets fully up to date with the canonical upstream copies, which includes some changes unrelated to the macOS ARM 64-bit build (details provided in the commit messages).
Demos from my fork: