Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate bumping Theia dependency to 1.30.x #1655

Closed
3 tasks done
per1234 opened this issue Nov 9, 2022 · 1 comment · Fixed by #1662
Closed
3 tasks done

Investigate bumping Theia dependency to 1.30.x #1655

per1234 opened this issue Nov 9, 2022 · 1 comment · Fixed by #1662
Assignees
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure topic: theia Related to the Theia IDE framework type: enhancement Proposed improvement

Comments

@per1234
Copy link
Contributor

per1234 commented Nov 9, 2022

Describe the request

Investigate the updating the version of the @theia package dependencies used by Arduino IDE to 1.30.x

Bumping the Theia version is likely to cause regressions, subsequent code changes may be required. Therefore this initial investigation task is needed as the first "phase" of the work to actually update the dependency.

Expected outcome

A clear breakdown of the major regressions when bumping the Theia version in IDE 2.x to 1.30.x, and a general estimate of overhead to resolve them.

🙂 It will be more clear how much work will be required to accomplish the dependency update and what previously unrecognized complications might be encountered.

Describe the current behavior

Arduino IDE 2.x is built on the Eclipse Theia IDE framework.

The Theia version currently in use in the Arduino IDE project is 1.25.0. Eight releases of Theia have been made since that time, which include significant advancements and relevant bug fixes.

🙁 At present we have outstanding issues that don't make sense to investigate until we've updated Theia as related behavior may differ between versions.

Arduino IDE version

3a70547

Operating system

All

Operating system version

Any

Additional context

Issues that may be resolved by a 1.30.x bump:

Issues that will only be resolved by a bump to >=1.31.0

Issue checklist

  • I searched for previous requests in the issue tracker
  • I verified the feature was still missing when using the latest nightly build
  • My request contains all necessary details
@per1234 per1234 added topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure topic: theia Related to the Theia IDE framework type: enhancement Proposed improvement labels Nov 9, 2022
@kittaakos
Copy link
Contributor

@91volt, Theia 1.31.0 comes with changes to have better accessibility support. Here and there the Theia styles contradict IDE2 styles. In this comment, I will attach screenshots depicting which UI parts are affected. (I will periodically update the comment with new findings if any.)

Screen Shot 2022-11-09 at 10 43 59

Screen Shot 2022-11-09 at 10 44 34

kittaakos pushed a commit that referenced this issue Nov 10, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 10, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 10, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 10, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 11, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 14, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 22, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos pushed a commit that referenced this issue Nov 23, 2022
Closes #1655

Signed-off-by: Akos Kitta <[email protected]>
kittaakos added a commit that referenced this issue Nov 29, 2022
Closes #1655
Closes #1656

Signed-off-by: Akos Kitta <[email protected]>
@per1234 per1234 added the conclusion: resolved Issue was resolved label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved topic: code Related to content of the project itself topic: infrastructure Related to project infrastructure topic: theia Related to the Theia IDE framework type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants