-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug view blank on first debugging session of a sketch #2354
Labels
conclusion: resolved
Issue was resolved
topic: code
Related to content of the project itself
topic: debugger
Related to the integrated debugger
type: imperfection
Perceived defect in any part of project
Comments
per1234
added
topic: code
Related to content of the project itself
type: imperfection
Perceived defect in any part of project
topic: debugger
Related to the integrated debugger
labels
Feb 7, 2024
kittaakos
pushed a commit
that referenced
this issue
Feb 8, 2024
Use customized `PanelLayout#removeWidget` and `PanelLayout#insertWidget` functions. The customized functions ensure no side effect when adding/removing the widget to/from the layout but it's already present/absent. Closes: #2354 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
that referenced
this issue
Feb 8, 2024
Use customized `PanelLayout#removeWidget` and `PanelLayout#insertWidget` logic for the layout updates. The customized functions ensure no side effect if adding/removing the widget to/from the layout but it's already present/absent. Unlike the default [`PanelLayout#removeWidget`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/widgets/src/panellayout.ts#L154-L156) behavior, do not try to remove the widget if it's not present (has a negative index). Otherwise, required widgets might be removed based on the default [`ArrayExt#removeAt`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/algorithm/src/array.ts#L1075-L1077) behavior. Closes: #2354 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
that referenced
this issue
Feb 8, 2024
Use customized `PanelLayout#removeWidget` and `PanelLayout#insertWidget` logic for the layout updates. The customized functions ensure no side effect if adding/removing the widget to/from the layout but it's already present/absent. Unlike the default [`PanelLayout#removeWidget`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/widgets/src/panellayout.ts#L154-L156) behavior, do not try to remove the widget if it's not present (has a negative index). Otherwise, required widgets might be removed based on the default [`ArrayExt#removeAt`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/algorithm/src/array.ts#L1075-L1077) behavior. Closes: #2354 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
that referenced
this issue
Feb 8, 2024
Use customized `PanelLayout#removeWidget` and `PanelLayout#insertWidget` logic for the layout updates. The customized functions ensure no side effect if adding/removing the widget to/from the layout but it's already present/absent. Unlike the default [`PanelLayout#removeWidget`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/widgets/src/panellayout.ts#L154-L156) behavior, do not try to remove the widget if it's not present (has a negative index). Otherwise, required widgets might be removed based on the default [`ArrayExt#removeAt`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/algorithm/src/array.ts#L1075-L1077) behavior. Closes: #2354 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
that referenced
this issue
Feb 8, 2024
Use customized `PanelLayout#removeWidget` and `PanelLayout#insertWidget` logic for the layout updates. The customized functions ensure no side effect if adding/removing the widget to/from the layout but it's already present/absent. Unlike the default [`PanelLayout#removeWidget`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/widgets/src/panellayout.ts#L154-L156) behavior, do not try to remove the widget if it's not present (has a negative index). Otherwise, required widgets might be removed based on the default [`ArrayExt#removeAt`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/algorithm/src/array.ts#L1075-L1077) behavior. Closes: #2354 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
pushed a commit
that referenced
this issue
Feb 14, 2024
Use customized `PanelLayout#removeWidget` and `PanelLayout#insertWidget` logic for the layout updates. The customized functions ensure no side effect if adding/removing the widget to/from the layout but it's already present/absent. Unlike the default [`PanelLayout#removeWidget`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/widgets/src/panellayout.ts#L154-L156) behavior, do not try to remove the widget if it's not present (has a negative index). Otherwise, required widgets might be removed based on the default [`ArrayExt#removeAt`](https://github.com/phosphorjs/phosphor/blob/9f5e11025b62d2c4a6fb59e2681ae1ed323dcde4/packages/algorithm/src/array.ts#L1075-L1077) behavior. Closes: #2354 Signed-off-by: Akos Kitta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
conclusion: resolved
Issue was resolved
topic: code
Related to content of the project itself
topic: debugger
Related to the integrated debugger
type: imperfection
Perceived defect in any part of project
Describe the problem
Arduino IDE has an integrated sketch debugger. The debugger interface is presented in a view in the left side panel of the Arduino IDE window. When the user initiates a debug session by clicking the "Start Debugging" button on the Arduino IDE toolbar, the "DEBUG" opens and the user can use the interface to debug their sketch.
🐛 On the first attempt to use the debugger with a given sketch, the "DEBUG" view is empty. It is only populated on the next IDE session.
To reproduce
🐛 The left side panel opens, but the "DEBUG" view is blank:
Expected behavior
The "DEBUG" view is always populated with the UI after the user clicks the "Start Debugging" button.
Arduino IDE version
2.3.0
Operating system
Operating system version
Additional context
I haven't done a full bisection, but I am not able to reproduce the fault with Arduino IDE 2.2.1.
I also sometimes encounter a partially populated view:
I haven't determined under which conditions that variant occurs vs. the fully blank view, but the workaround applies to both.
Workaround
The "DEBUG" panel will now be populated with the standard debugger UI.
The debugger will now be initialized and work as usual.
Issue checklist
The text was updated successfully, but these errors were encountered: