#53 Refresh menus when opening example/recent fails.

[kittaakos]

Motivation

IDE2 must notify the user about missing/invalid sketches and update the menus when opening the sketch has failed. This is the expected behavior when opening from File > Open Recent, File > Sketchbook, and File > Examples.

Change description

Other information

Closes #53

Reviewer checklist

• PR addresses a single concern.
• The PR has no duplicates (please search among the Pull Requests before creating one)
• PR title and description are properly filled.
• Docs have been added / updated (for bug fixes / features)

[AlbyIanna]

LGTM 🚀

[kittaakos]

I have rebased the PR from the main. Please review it. Thank you!

[AlbyIanna]

Still working for me ✅

[per1234]

UPDATE: resolved by https://github.com/arduino/arduino-ide/compare/c8388a78582727a0bf0b869c097714aad1fd8eca..bc85ea62d6e7b6cc80ffbe78a98f898d76ce8a76

Describe the problem

File > New has no effect.

To reproduce

1. Select File > New from the Arduino IDE menus.

🐛 Nothing at all happens.

Expected behavior

A new sketch opens in an additional Arduino IDE window after selecting File > New

Arduino IDE version

2.0.1-snapshot-0359e42 (tester build for 0359e42)

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Additional context

The problem does not occur when using the latest build from the main branch (2.0.1-snapshot-96cf09d)

[per1234]

UPDATE: resolved by https://github.com/arduino/arduino-ide/compare/c8388a78582727a0bf0b869c097714aad1fd8eca..bc85ea62d6e7b6cc80ffbe78a98f898d76ce8a76

Describe the problem

IDE fails to start if no sketch was opened previously.

To reproduce

1. Select File > Quit from the Arduino IDE menus if it is running.
2. Rename or delete (:warning: cautiously) the following folders to simulate the environment of a first run:
   • Windows:

     C:\Users\<username>\.arduinoIDE
     

     C:\Users\<user name>\AppData\Roaming\arduino-ide
     

   • Linux:

     ~/.arduinoIDE
     

     ~/.config/arduino-ide
     

   • macOS:

     ~/.arduinoIDE
     

     ~/Library/Application Support/arduino-ide
     

3. Start the build of the Arduino IDE for this PR.
   🐛 The IDE hangs forever at the startup animation.
4. Close the Arduino IDE window.
5. Start a previous version (e.g., 2.0.0) of the Arduino IDE 2.x.
6. Select File > Save As... from the Arduino IDE menus.
   ⓘ This is done to cause a previously open sketch to be recorded for restoration the next time the IDE is opened. You could do the same by opening any previously saved sketch.
7. Select File > Quit from the Arduino IDE menus.
8. Start the build of the Arduino IDE for this PR.
   🙂 The IDE startup finishes.

Expected behavior

Arduino IDE starts even when there is no previously opened sketch.

Arduino IDE version

2.0.1-snapshot-0359e42 (tester build for 0359e42)

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Additional context

The problem does not occur when using the latest build from the main branch (2.0.1-snapshot-96cf09d)

[kittaakos]

Thank you for the review, Per. I have fixed the bug with the new sketch creation; it should solve both issues you had during the verification.

[per1234]

Describe the problem

File > Open Recent never populates if no sketch was opened previously.

To reproduce

1. Select File > Quit from the Arduino IDE menus if it is running.
2. Rename or delete (:warning: cautiously) the configuration folder to adequately simulate the environment of a first run:
   • Windows:

     C:\Users\<username>\.arduinoIDE
     

   • Linux:

     ~/.arduinoIDE
     

   • macOS:

     ~/.arduinoIDE
     

3. Start the build of the Arduino IDE for this PR.
4. Select File > Save As... from the Arduino IDE menus.
5. Save the sketch to any convenient name and location.
6. Open the File menu.
   🐛 There is no Open Recent menu item
7. Select File > Quit from the Arduino IDE menus.
8. Start a previous version (e.g., 2.0.0) of Arduino IDE 2.x.
9. Open the File menu.
   🙂 There is an "Open Recent" menu item
10. Select File > Quit from the Arduino IDE menus.
11. Start the build of the Arduino IDE for this PR.
12. Open the File menu.
    🙂 There is an "Open Recent" menu item

Expected behavior

File > Open Recent menu is populated with the recently opened sketch.

Arduino IDE version

2.0.1-snapshot-6888b6c (tester build for bc85ea6)

Operating system

Windows, Linux

Operating system version

Windows 10, Ubuntu 20.04

Additional context

The problem does not occur when using the ~latest build from the main branch (2.0.1-snapshot-96cf09d)

[kittaakos]

• Start the build of the Arduino IDE for this PR.
• Select File > Save As... from the Arduino IDE menus.

After wiping the config folder and starting the IDE2, would you expect to see File > Open Recent > Foo, assuming that the Foo sketch was the last IDE2 restored? Thank you!

[per1234]

would you expect to see File > Open Recent > Foo, assuming that the Foo sketch was the last IDE2 restored?

No, but I also wouldn't be surprised to see that, so either way is fine. I only expect that any sketches I open after that to be added to the menu.

[kittaakos]

I also wouldn't be surprised to see that, so either way is fine

Thank you!

IDE2 will show it. Steps to reproduce:

• Open IDE2, create a sketch, and save it to Sketchbook, File > Quit the app,
• Wipe ~/.arduinoIDE/recent-sketches.json (or rename it),
• Start IDE2. If IDE2 could restore a non-temp sketch, the File > Open Recent should contain the corresponding submenu item.

I fixed another use case. It wasn't working. Steps:

• Open IDE2, open 3-4 valid sketches from the Sketchbook, File > Quit the app,
• Wipe ~/.arduinoIDE/recent-sketches.json (or rename it),
• Start IDE2. IDE2 should restore all previously opened sketches. Go to File > Quit > all opened sketches must have a corresponding submenu item.

Thank you so much for doing the PR review, again and again, Per. All issues you have noticed during the verification should be fixed now.

[per1234]

It is working perfectly for me now.

Thanks for this very nice improvement to the user experience Akos!