feat: no remote fetch when IDE gets CLI version #1802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To speed up the load time of the About dialog in IDE2. As requested in #1572, IDE2 reads the CLI version from the
package.json
.Change description
2.0.3:
A dev build with the changes:
Local IDE2 build with the changes:
Other information
If the CLI version is a pinned commitish and not a semver, IDE2 will show the commitsh.
Assuming the following pinned CLI version:
The expected About dialog (with a dev build) is:
Closes #1572
It should be possible to run
arduino-cli version --no-fetch
or similar to avoid checking for updates. I have never used a CLI tool before that does a silent remote fetch when getting the only version. If there is a good example, please let me know. CLIs usually warn about the outdated version (brew
,npm
,yarn
, etc.) when users execute a command that requires the Intenet connection. The Arduino CLI ought to warn the user oncore index-update
orlib install
but not onversion
.Reviewer checklist