Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Examples and Include Library menu after ZIP install #1807

Merged
merged 1 commit into from
Jan 11, 2023
Merged

fix: update Examples and Include Library menu after ZIP install #1807

merged 1 commit into from
Jan 11, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

After installing a library from a ZIP, IDE2 must update the File > Examples and Sketch > Include Library menus to show the freshly installed library (if the selected board is appropriate).

Steps to verify:

  • You have the AVR core installed, start IDE2 and select the Uno board,
  • Check File > Examples and Sketch > Include Library menus, ArduinoMDNS is not present.
  • Follow the steps from Dependent menus not updated after .zip library install #659, they're excellent, and the get the library from the ZIP,
  • Install it with Sketch > Include Library > Add ZIP Library...
  • After the installation, check the File > Examples and Sketch > Include Library menus, ArduinoMDNS is present.
659.mp4

Change description

Closes #659

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

@kittaakos kittaakos added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Jan 9, 2023
AlbyIanna
AlbyIanna approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me and code looks good!

@kittaakos kittaakos merged commit b2bf368 into main Jan 11, 2023
@kittaakos kittaakos deleted the #659 branch January 11, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dependent menus not updated after .zip library install
2 participants
@kittaakos @AlbyIanna