Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: can force notarization on macOS if not on a CI #1916

Merged
merged 1 commit into from
Feb 27, 2023
Merged

build: can force notarization on macOS if not on a CI #1916

merged 1 commit into from
Feb 27, 2023

Conversation

kittaakos
Copy link
Contributor

Motivation

IDE2 needs a way to manually sign the application on M1. The 'MACOS_FORCE_NOTARIZE' env variable forces the notarization to proceed if not on a CI.

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

build: force notarization on macOS if not on a CI
7778505 
IDE2 needs a way to manually sign the application on M1.
The 'MACOS_FORCE_NOTARIZE' env variable forces the
notarization to proceed if not on a CI.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos self-assigned this Feb 24, 2023
@kittaakos kittaakos added the topic: code Related to content of the project itself label Feb 24, 2023
@kittaakos kittaakos changed the title build: force notarization on macOS if not on a CI build: can force notarization on macOS if not on a CI Feb 24, 2023
AlbyIanna
AlbyIanna approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@AlbyIanna AlbyIanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kittaakos kittaakos merged commit c0af297 into main Feb 27, 2023
@kittaakos kittaakos deleted the manual-macos-m1-release branch February 27, 2023 08:52
@per1234 per1234 added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure os: macos Specific to macOS operating system and removed topic: code Related to content of the project itself labels Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbyIanna AlbyIanna AlbyIanna approved these changes

@per1234 per1234 Awaiting requested review from per1234

Assignees

@kittaakos kittaakos

Labels
os: macos Specific to macOS operating system topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittaakos @AlbyIanna @per1234