Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-merge: added a preference to reproduce #1791 #1970

Closed
wants to merge 1 commit into from

Conversation

kittaakos
Copy link
Contributor

NO MERGE

Motivation

This is a PR to help reproduce #1791 and prove that #1969 is correct.

There is a new preference to control the editor timeout when opening the sketch files.

Hardcoded in the main:

const timeout = 5_000; // number of ms IDE2 waits for the editor to show up in the UI

New preference in this branch:
arduino.sketch.editorOpenTimeout. The default value is 5000 ms.

How to use:

  • When you create a new sketch, all works fine. The editor timeout is 5000 ms.
default_editor_timeout.mp4
  • Open the settings JSON and set arduino.sketch.editorOpenTimeout to 1. Ensure your settings.json is saved, and create a new sketch. You see the duplicate tabs.
min_editor_timeout.mp4

Change description

Other information

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

the smaller the timeout the better chance you have to see the duplicate editors.

Signed-off-by: Akos Kitta <[email protected]>
@kittaakos kittaakos added conclusion: invalid Issue/PR not valid topic: code Related to content of the project itself labels Mar 20, 2023
@kittaakos kittaakos requested a review from per1234 March 20, 2023 14:01
@kittaakos kittaakos self-assigned this Mar 20, 2023
@kittaakos kittaakos added status: on hold Do not proceed at this time and removed conclusion: invalid Issue/PR not valid labels Mar 21, 2023
@kittaakos
Copy link
Contributor Author

This PR was created to simplify the verification of #1969.

@kittaakos kittaakos closed this Mar 27, 2023
@kittaakos kittaakos deleted the reproduce-1791 branch March 27, 2023 08:22
@per1234 per1234 added conclusion: duplicate Has already been submitted and removed status: on hold Do not proceed at this time labels Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: duplicate Has already been submitted topic: code Related to content of the project itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants