fix: reduced unnecessary GET /sketches
request
#2014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR slightly modifies the implementation of arduino/arduino-ide#875 to reduce the unnecessary
GET /sketches
. The endpoint claims to support pagination, but it does not. So if the number of sketches can be divided by thelimit
without a remainder, another fetch is required.This PR does not change the limit but leaves it at 50. This PR adds tests to verify the new behavior. Note that those tests do not run on the CI, only locally when secrets are set in the environment.
To verify:
Change description
Other information
Reviewer checklist