fix: remove setting unsafe innerHTML
#2064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is vulnerable to stored Cross-Site Scripting. Ref: PNX-3669 Signed-off-by: Akos Kitta <[email protected]>
kittaakos
added
topic: code
rhpco
approved these changes
May 11, 2023
| @@ -95,6 +95,22 @@ export class LibraryListWidget extends ListWidget< | |||
| item.name, | |||
| version | |||
| ); | |||
| const segments = splitByBoldTag(textContent); | |||
| if (!segments) { | |||
| message.textContent = textContent; | |||
per1234
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Setting the
innerHTMLin an unsafe way has been removed, as it is vulnerable to stored Cross-Site Scripting.Change description
I have replaced the
innerHTMLwith a series of<span>elements optionally containing a<b>child. Neither functional nor style changes are expected in IDE2.2.1.0look and feel vs. the build from this PR:2.1.0DOM:DOM from this PR:
Steps to verify:
ArduinoIoTCloudlibrary installed, uninstall it,ArduinoIoTCloudlibrary,2.1.0release. They should be the same.Other information
Ref: PNX-3669
Reviewer checklist