Add 中文(繁體) ("Chinese (Traditional)") localization #2151
Conversation
|
|
There was a problem hiding this comment.
Hi @coby2023t. Thanks for your pull request.
Please provide a detailed explanation of the changes this pull request makes to the localization data in the i18n/zh_Hant.json and i18n/zh_TW.json files.
These files are automatically generated from the source data in the "Arduino IDE 2.0" project on the Transifex localization platform. So we don't ever expect that a pull request submitted by a human would touch these files. Translation contributions must be done via Transifex. The reason is that any translations contributed directly to this repository would be overridden on the next automated sync from Transifex.
per1234
added
type: enhancement
|
ide 2.0 lack lots of l10n packages for many languages, it's a good idea to keep people to use the way they familiar with as old days. little fix for my capable knowledge. I will try transifex for the po file. |
There is a related issue here: #1447 |
per1234
changed the title
per1234
changed the title
This will add a "中文(繁體)" option to the "Language" menu in the Arduino IDE preferences, which will cause the strings in the IDE UI to be localized for "Chinese (Traditional)". In addition to the translations for the strings that originate from the Eclipse Theia IDE framework provided by the "Chinese (Traditional) Language Pack for Visual Studio Code" language pack, this will also utilize the translations of the Arduino IDE-specific strings contributed by the community.
Contributions to the translations can only be made via the Transifex localization framework, from which they are automatically pulled into this repository. Contributions made directly to the data files as was done by the previous commit would be lost on the next Transifex pull.
A convention has been established of ordering the lists of locale-related items in the configurations used by the project's internationalization system. Items were inserted at inappropriate locations by a previous commit.
There was a problem hiding this comment.
Since I didn't get an indication that @coby2023t planned to update the PR according to my previous review, I went ahead and pushed a commit to remove the inappropriately submitted localization data:
@coby2023t please do submit those translations via Transifex. Your contributions would be very welcome there. There is information about how to contribute translations here:
https://github.com/arduino/arduino-ide/blob/main/docs/contributor-guide/translation.md
Thanks in advance!
I also pushed some clean up commits to bring the quality of the contribution up to the standards of this project:
I have verified that the changes proposed here are correct and beneficial. I also tested them. So everything is now good from my perspective, but I will wait a while to offer @kittaakos the opportunity to also review before merging.
There was a problem hiding this comment.
The changes look good to me. Thank you for the contribution, @coby2023t 👍
Please squash merge the changes. IDE2 does not need four commits in the history for this feature. Thank you!
Motivation
Community contributions of translations for the "Chinese Traditional" language have reached 84% coverage of the Arduino IDE-specific UI strings in the "Arduino IDE 2.0" project on the Transifex localization platform.
A "Chinese (Traditional) Language Pack for Visual Studio Code" language pack is available, which provides the ability to ship those translations to the Arduino IDE users in addition to the translations for the strings that originate from the Eclipse Theia IDE framework contained in the language pack.
Change description
This will add a "中文(繁體)" option to the "Language" menu in the Arduino IDE preferences, which will cause the strings in the IDE UI to be localized for "Chinese (Traditional)".
Other information
Provides a partial resolution for #712
Reviewer checklist