-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use new debug -I -P
CLI output
#2281
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
added
type: enhancement
Proposed improvement
topic: code
Related to content of the project itself
topic: CLI
Related to Arduino CLI
topic: debugger
Related to the integrated debugger
labels
Nov 13, 2023
kittaakos
force-pushed
the
new-debug-info-format
branch
from
November 13, 2023 11:09
691dec6
to
0edc8e0
Compare
4 tasks
kittaakos
force-pushed
the
new-debug-info-format
branch
2 times, most recently
from
November 13, 2023 15:28
5b65848
to
33dd2a7
Compare
4 tasks
4 tasks
kittaakos
force-pushed
the
new-debug-info-format
branch
from
November 17, 2023 14:19
9f7feff
to
353dfac
Compare
This was referenced Nov 17, 2023
davegarthsimpson
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code approved, I didn't see anything problematic
umbynos
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works. Nice work! 🛩️
Closes #2270 Signed-off-by: Akos Kitta <[email protected]>
Ref: arduino/arduino-cli#2374 Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
- Related change: 153e34f - Reported at: #2267 (comment) - External: https://forum.arduino.cc/t/ide-2-2-1-main-window-randomly-goes-blank/1166219 Signed-off-by: Akos Kitta <[email protected]>
A new startup task ensures setting any custom board menu selection in a new sketch window. Closes #2271 Signed-off-by: Akos Kitta <[email protected]>
Hide the concrete implementation behind an interface so that tests can `require` it. Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
- Can pick a programmer if missing, - Can auto-select a programmer on app start, - Can edit the `launch.json`, - Adjust board discovery to new gRPC API. From now on, it's a client read stream, not a duplex. - Allow `.cxx` and `.cc` file extensions. (Closes #2265) - Drop `debuggingSupported` from `BoardDetails`. - Dedicated service endpoint for checking the debugger. Signed-off-by: Akos Kitta <[email protected]>
kittaakos
force-pushed
the
new-debug-info-format
branch
from
December 13, 2023 15:23
fed8152
to
35ca43a
Compare
4 tasks
4 tasks
3 tasks
1 task
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
topic: CLI
Related to Arduino CLI
topic: code
Related to content of the project itself
topic: debugger
Related to the integrated debugger
type: enhancement
Proposed improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2294 and #2289.They're part of this PR ✅Motivation
Use the CLI's new
debug --info --programmer
output for IDE2 debugging.Change description
0.35.0-rc.7
.0.7.5
.0.1.0
. (Download the VSIX.).cxx
and.cc
file extensions.v
prefix in the CLI's GitHub release name when generating JS/TS fromproto
.launch.json
configuration file.(in Sketchbook)
tooltip suffix in the board select dialog for manually installed boards.Dependencies:
[email protected]
. (See chore(deps): update to[email protected]
. #2277 (comment) and chore(cli): update CLI to0.35.0-rc.2
#2267 (comment))Noteworthy UI changes:
Show the tooltip suffix if the core has been installed manually
tooltip_suffix_if_manually_installed.mp4
Intellisense and validation for
custom_debug.json
debug_custom_json.mp4
Show progress information in the status bar when
debug --info --programmer
is running by the CLIget_debug_info.mp4
Prompt user for a programmer when not selected for the debug session
prompt_select_programmer.mp4
From now on, IDE2 gives advanced users the flexibility to modify the
launch.json
edit_launch_config.mp4
Can debug the same sketch with multiple boards
can_debug_with_multiple_boards.mp4
BREAKING:
debug_custom.json
.Other information
Closes #2265
Closes #2270
Upstream PR: arduino/vscode-arduino-tools#41
Reviewer checklist