Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IDE updater commands #872

Merged
merged 3 commits into from
Mar 1, 2022
Merged

fix IDE updater commands #872

merged 3 commits into from
Mar 1, 2022

Conversation

AlbyIanna
Copy link
Contributor

Motivation

IDE updater commands are not working how expected. They work, but they are not giving any feedback to the user.

Change description

Remove useless commands. Leave only the "Check for Arduino IDE updates" command. When launching this command, if there is an update available, it opens the update dialog. If there isn't any update available or some error occurs, it shows a notification message.

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

Base automatically changed from custom-update-url to main February 28, 2022 14:04
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Mar 1, 2022
@per1234
Copy link
Contributor

per1234 commented Mar 1, 2022

@AlbyIanna if you still want me to check this out, please do a rebase to trigger a build. The build workflow is configured to only run on PRs submitted to the main branch, so it didn't run on the previous push. Now that the base has been changed to main it will run on the next update to the PR.

But I see Francesco already gave it the 👍, so it is good to merge right away.

@AlbyIanna
Copy link
Contributor Author

@per1234 ✅ done!

@AlbyIanna
Copy link
Contributor Author

@per1234 I've just realised I'm not updating the channel configuration immediately when the user changes the channel preference. It's not done until the next IDE start-up. I'm going to fix it in this PR because I think it's pertinent.

@AlbyIanna
Copy link
Contributor Author

@per1234 Done. Now it should work as expected, that is when you change the channel or the update URL and then check for updates, the updater will use the correct channel/URL.

P.S.: I've noticed the expand/collapse icons in the bottom-right notifications are "invisible". Fixing it in another PR.

@per1234 per1234 linked an issue Mar 1, 2022 that may be closed by this pull request
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had noticed the previous somewhat odd behavior of the commands, where you had to use a sequence of commands like this to trigger an update:

  1. Arduino: Check for Arduino IDE updates
  2. Arduino: Download Arduino IDE updates
  3. Arduino: Install Arduino IDE updates

After which it would do the update regardless of whether the available version was newer than the current.

With this PR, the single command Arduino: Check for Arduino IDE updates does all that, and works the same as the automatic update offer. So I think it is a very nice improvement.

and also thought that the ones other than Arduino: Check for Arduino IDE updates didn't seem very useful. So I think this is a nice change.


I verified that this also fixes #847


Thanks Alberto!

@AlbyIanna AlbyIanna merged commit 96b5edf into main Mar 1, 2022
@AlbyIanna AlbyIanna deleted the fix-updater-commands branch March 1, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update channel setting change recognized only after IDE restart
3 participants