Bump release workflow to match the template in the tooling-project-assets repository #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
force-pushed
the
move-to-gon-fork
branch
from
2c121cd
to
f341e15
Compare
umbynos
reviewed
Nov 23, 2023
umbynos
reviewed
Nov 23, 2023
umbynos
requested changes
Nov 23, 2023
umbynos
reviewed
Nov 28, 2023
MatteoPologruto
force-pushed
the
move-to-gon-fork
branch
2 times, most recently
from
a96768c
to
1bba2a7
Compare
MatteoPologruto
force-pushed
the
move-to-gon-fork
branch
2 times, most recently
from
d62dfd1
to
6f728dd
Compare
umbynos
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An excellent tool named gon was used to perform the notarization.
the latest stable release of gon uses the altool command-line utility for notarization:
https://github.com/mitchellh/gon/blob/v0.2.5/notarize/upload.go#L41
Using altool for notarization is now deprecated by Apple and support for notarization via this tool is scheduled to be disabled 2023-11-01:
https://developer.apple.com/news/?id=y5mjxqmn
Furthermore, gon was archived.
I switched to https://github.com/Bearer/gon that has included mitchellh/gon#72, hoping the maintainers will take the responsibility of maintaining the project.
I added also AC_PROVIDER env var which is mandatory with the new notarytool.
Overall, the workflow was bumped to match the template in the
tooling-project-assetsrepository.Pull request type