Avoid running publish-go-tester-task if tag is set #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
type: imperfection
per1234
requested changes
Dec 13, 2022
MatteoPologruto
force-pushed
the
tester-build-tag-run
branch
from
71d34f0
to
dee8819
Compare
|
@MatteoPologruto I see the merge is blocked because the required spellcheck workflow job run didn't trigger on the last push. I have no idea why it didn't run. It is likely just a transient glitch in GitHub Actions. Please let me know if you are ready to merge this and I'll take care of overriding the requirement and merging it (you have the permissions to do it also, but I already am familiar with what needs to be done so it will be most efficient for me to take care of it in this case). |
|
Hi @per1234, I'm ready to merge. I could also try to re-trigger a spellcheck workflow run by force pushing the same commit. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publish-go-tester-task runs when a tag is pushed. Since the tag has priority when version is defined, the workflow fails because it does not find any build named
test-XXX-git-snapshotwhen calculating the checksums. It recently happened here: https://github.com/arduino/arduino-cli/actions/runs/3480562942/jobs/5820576240#step:3:16To fix this issue, during
run-determination, the presence of a tag is checked comparinggithub.refwithTAG_REGEX. If there is a match, the other jobs are skipped, preventing the workflow from failing at later stages.