Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license headers check in go files #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add license headers check in go files #354

wants to merge 1 commit into from

Conversation

alessio-perugini
Copy link
Contributor

@alessio-perugini alessio-perugini commented May 17, 2023 •
edited
Loading

SSIA.

Also linked to arduino/arduino-cli#2177

@CLAassistant
Copy link

CLAassistant commented May 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alessio-perugini alessio-perugini self-assigned this May 17, 2023
@alessio-perugini alessio-perugini changed the title add the license headers check in go files Add license headers check in go files May 17, 2023
@alessio-perugini alessio-perugini added the type: enhancement Proposed improvement label May 17, 2023
umbynos
umbynos requested changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I would only like to have a license_header.tpl template in this PR. This repo is intended to make copy-paste possible with minimal configuration and not having that file or at least instructions on how to structure it is a problem

@per1234 per1234 added the topic: code Related to content of the project itself label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umbynos umbynos umbynos requested changes

@per1234 per1234 Awaiting requested review from per1234

Requested changes must be addressed to merge this pull request.

Assignees

@alessio-perugini alessio-perugini

Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alessio-perugini @CLAassistant @umbynos @per1234