Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iss72: CircleCI #73

Closed
wants to merge 53 commits into from
Closed

Iss72: CircleCI #73

wants to merge 53 commits into from

Conversation

samgdotson
Copy link
Collaborator

Things I'm not sure about:

  • Test that CircleCI will run on this repository
    • Does it need to be configured on your end @katyhuff ?
  • Does CircleCI require a virtual environment?
    • ... and therefore require a requirements.txt file.

The tests in the master branch all pass, currently. I will keep working on this as needed.

@samgdotson samgdotson added Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:2-Normal This work is important and should be completed ASAP. Status:4-In Progress This is actively being worked on by the assignee. Type:Feature New feature or feature request Type:Test Is related to software testing. Failing tests, necessary new tests, test frameworks, etc. labels Jul 7, 2020
@samgdotson samgdotson linked an issue Jul 7, 2020 that may be closed by this pull request
@katyhuff
Copy link
Member

Please resolve conflicts, this may fix the situation with many commits being shown that are not actually part of this atomic PR.

@katyhuff katyhuff removed their request for review August 17, 2020 23:14
@katyhuff
Copy link
Member

katyhuff commented Oct 6, 2020

Conflicts building up. There were some circa Jul 20, but there are more now that the reservoir computing paper is in.

@samgdotson
Copy link
Collaborator Author

This PR is being closed because CircleCI is being configured directly from the CircleCI website.

@samgdotson samgdotson closed this Nov 4, 2020
@samgdotson samgdotson deleted the iss72 branch November 4, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Comp:Build This issue has to do with the build system of the code/doc (makefiles, cmake, install errors) Difficulty:2-Challenging This issue may be complex or require specialized skills. Priority:2-Normal This work is important and should be completed ASAP. Status:4-In Progress This is actively being worked on by the assignee. Type:Feature New feature or feature request Type:Test Is related to software testing. Failing tests, necessary new tests, test frameworks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI
3 participants