✨ Fix issue (#3637)

Here you can see the error 👇 https://github.com/argilla-io/argilla/assets/7398909/0c755985-0493-4c62-8850-9115f0c6e43e
argilla-io · Aug 28, 2023 · 605ebb1 · 605ebb1
1 parent bc743f5
commit 605ebb1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...orms/questions-form/fields/shared-components/question-header/QuestionHeader.component.vue b/...orms/questions-form/fields/shared-components/question-header/QuestionHeader.component.vue
@@ -6,7 +6,7 @@
       v-required-field="{ show: question.isRequired, color: 'red' }"
       v-prefix-star="{
         enabled: showSuggestion,
-        show: matchSuggestion,
+        show: question.matchSuggestion,
         tooltip: 'This question contains a suggestion',
       }"
     />
@@ -45,7 +45,6 @@ export default {
   },
   data() {
     return {
-      matchSuggestion: this.question.matchSuggestion,
       tooltipMessage: this.question.description,
       openTooltip: false,
       timer: null,
@@ -57,9 +56,6 @@ export default {
     },
   },
   watch: {
-    "question.matchSuggestion"() {
-      this.matchSuggestion = this.question.matchSuggestion;
-    },
     "question.description"() {
       if (this.timer) clearTimeout(this.timer);
       this.openTooltip = true;

diff --git a/frontend/plugins/directives/prefix-star.directive.js b/frontend/plugins/directives/prefix-star.directive.js
@@ -10,7 +10,8 @@ const sparkIcon = {
     element.prepend(emojiWrapper);
   },
   remove: (element) => {
-    element.removeChild(element.childNodes[0]);
+    if (element.childNodes.length === 2)
+      element.removeChild(element.childNodes[0]);
   },
 };