Skip to content

Commit

Permalink
Log if a dataset is deleted (#4752)
Browse files Browse the repository at this point in the history
# Generic Pull Request Template

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

Closes #4751

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

**Checklist**

- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
  • Loading branch information
paulbauriegel authored May 13, 2024
1 parent a88c818 commit 7720dc4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/argilla/client/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ def delete(self, name: str, workspace: Optional[str] = None):
if workspace is not None:
self.set_workspace(workspace)

_LOGGER.info(f"Dataset {name} is being delete by {self._user.id}")
datasets_api.delete_dataset(client=self.http_client, name=name)

def log(
Expand Down

0 comments on commit 7720dc4

Please sign in to comment.