Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍓 Automate year shown in UI and sites #2569

Closed
nataliaElv opened this issue Mar 17, 2023 · 6 comments
Closed

🍓 Automate year shown in UI and sites #2569

nataliaElv opened this issue Mar 17, 2023 · 6 comments
Assignees
Labels
type: enhancement Indicates new feature requests

Comments

@nataliaElv
Copy link
Member

Is your feature request related to a problem? Please describe.
The year shown in Argilla UI, docs and website is outdated.

Describe the solution you'd like
Automate the year that is displayed in these sites.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@nataliaElv nataliaElv added the type: enhancement Indicates new feature requests label Mar 17, 2023
@tomaarsen
Copy link
Contributor

Click here for screenshots

image
image
image

The docs take the copyright from here:

copyright = "2022, Argilla.io"

@leiyre
Copy link
Member

leiyre commented Mar 17, 2023

leiyre added a commit that referenced this issue Mar 17, 2023
# Description

This PR includes an automation to calculate the year in copyright

See #2569

**Type of change**

- [x] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**

**Checklist**

- [x] I have merged the original branch into my forked branch
- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)
@frascuchon frascuchon modified the milestone: v1.6.0 Mar 21, 2023
@Amelie-V
Copy link
Member

How can we finish this update? @nataliaElv

@Amelie-V Amelie-V changed the title Automate year shown in UI and sites 🍓 Automate year shown in UI and sites Mar 24, 2023
@nataliaElv
Copy link
Member Author

I'll give it a go on Monday. It shouldn't be difficult 😃

@jfcalvo
Copy link
Member

jfcalvo commented Mar 24, 2023

I'll give it a go on Monday. It shouldn't be difficult 😃

Sorry I just saw this. BTW what about fixing this too on the corporate website? (I mean at https://argilla.io) Looks like is showing 2023 but probably is some static string.

@jfcalvo
Copy link
Member

jfcalvo commented Mar 27, 2023

I'll give it a go on Monday. It shouldn't be difficult 😃

Sorry I just saw this. BTW what about fixing this too on the corporate website? (I mean at https://argilla.io) Looks like is showing 2023 but probably is some static string.

@leiyre already changed it to be dynamic.

jfcalvo added a commit that referenced this issue Mar 27, 2023
# Description

This PR changes how `copyright` docs attribute is set. Now instead of a
fix string we are getting dynamically the current year.

See
#2569 (comment)

**Type of change**

- [x] Improvement (change adding some improvement to an existing
functionality)

**How Has This Been Tested**
 
- [x] I have locally generated the documentation and I can see that the
copyright footer on the generated documentation is showing the current
year.

**Checklist**

- [x] I have merged the original branch into my forked branch.
- [x] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] <del>I have added tests that prove my fix is effective or that my
feature works</del> Not necessary.
- [ ] <del>I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)</del> Not necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Indicates new feature requests
Projects
None yet
Development

No branches or pull requests

7 participants