Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] pin Pydantic to < 2 #3348

Closed
davidberenstein1957 opened this issue Jul 6, 2023 · 0 comments · Fixed by #3349
Closed

[BUG] pin Pydantic to < 2 #3348

davidberenstein1957 opened this issue Jul 6, 2023 · 0 comments · Fixed by #3349
Assignees
@frascuchon
Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints type: bug Indicates an unexpected problem or unintended behavior

Comments

@davidberenstein1957
Copy link
Member

Describe the bug
Pydantic is not backwards compatible.

Stacktrace and Code to create the bug
N.A.
Expected behavior
A clear and concise description of what you expected to happen.

Environment:

  • Argilla Version [e.g. 1.0.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. argilla:v1.0.0]:

Additional context
Add any other context about the problem here.
@davidberenstein1957 davidberenstein1957 added type: bug Indicates an unexpected problem or unintended behavior ux area: ui Indicates that an issue or pull request is related to the User Interface (UI) area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints labels Jul 6, 2023
@davidberenstein1957 davidberenstein1957 removed ux area: ui Indicates that an issue or pull request is related to the User Interface (UI) labels Jul 6, 2023
@frascuchon frascuchon mentioned this issue Jul 6, 2023
Merged
9 tasks
@davidberenstein1957 davidberenstein1957 linked a pull request Jul 6, 2023 that will close this issue
fix: Set pydantic < 2.0 #3349
Merged
9 tasks
davidberenstein1957 added a commit that referenced this issue Jul 6, 2023
@frascuchon @davidberenstein1957
fix: Set pydantic < 2.0 (#3349)
08942db 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

The new pydantic version 2.0 is not compatible with Argilla. The
dependency is pinned to < 2.0

Also, the doc generation is reviewed, and fixed some missing deps.

Closes #3348

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [X] Bug fix (non-breaking change which fixes an issue)

**Checklist**

- [ ] I added relevant documentation
- [x] follows the style guidelines of this project
- [x] I did a self-review of my code
- [x] I made corresponding changes to the documentation
- [x] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [x] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: David Berenstein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frascuchon frascuchon

Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Set pydantic < 2.0 argilla-io/argilla
3 participants
@frascuchon @davidberenstein1957 @Amelie-V