[FEATURE] Add workspace_id to GET /api/v1/me/datasets
#3726
Comments
13 tasks
alvarobartt
added a commit
that referenced
this issue
Sep 7, 2023
# Description This PR adds the `workspace_id` param to `GET /api/v1/me/datasets` so that the workspace filtering when listing `FeedbackTask` datasets is applied in the API-side, as well as making sure that no local filters are applied e.g. `FeedbackDataset.list(workspace=...)` Closes #3726 **Type of change** - [X] New feature (non-breaking change which adds functionality) - [X] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** - [x] Add tests for `GET /api/v1/me/datasets` using the `workspace_id` param, including also the updated policies for non-owner users - [x] Add tests for `list_datasets` in the Python SDK using the `workspace_id` arg - [x] Add tests for `FeedbackDataset.list` in the Python client using the `workspace` arg **Checklist** - [X] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: Gabriel Martín Blázquez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the solution you'd like
The filtering when listing
FeedbackDatasetdatasets to be applied in the API-side rather than locally once all theFeedbackDatasetdatasets have been pulled from the API. So on, this implies adding theworkspace_idparam to theGET /api/v1/me/datasetsendpoint, as well as removing thefor dataset in datasets if dataset.workspace == workspace_idfiltering in the Python client side.The text was updated successfully, but these errors were encountered: