[BUG-python/deployment] backwards compatibility src/argilla/client/sdk/v1/datasets/api.py get_metadata_properties

[davidberenstein1957]

Describe the bug
Whenever retrieving a dataset from server 1.17 with client 1.19 there seems to be an incompatibility issue when calling response.json. I think this might be a more recurrent issue, where for some reason the response does return with response.status_code==200 even though the endpoint is not defined in FastAPI. Hence this might also occur with the semantic search update.

Stacktrace and Code to create the bug

argilla/src/argilla/client/sdk/v1/datasets/api.py

Line 423 in 38c2799

def get_metadata_properties(

Try loading a dataset from the 1.17 server with a 1.19 client.

Expected behavior
A clear and concise description of what you expected to happen.

Environment:

• Argilla Version [e.g. 1.0.0]: 1.19
• ElasticSearch Version [e.g. 7.10.2]: N.A.
• Docker Image (optional) [e.g. argilla:v1.0.0]: 1.17

Additional context
N.A.

[davidberenstein1957]

ahh nop, is the 404 page
is the frontend redirection
Ideally, the frontend should be mounted in a different path for example argilla.io/ui. for the ui and argilla.io/api for the api. This will simplify to handle this kind of problems

[frascuchon]

The 404 page returned is returning a 200 status code, but it should return a 404. Not sure if this can be handled by the frontend application in an easy way @damianpumar

curl -I -XGET http://localhost:6900/bad-url

HTTP/1.1 200 OK
date: Sat, 11 Nov 2023 14:41:43 GMT
server: uvicorn
content-type: text/html; charset=utf-8
content-length: 3343
last-modified: Sat, 11 Nov 2023 14:38:57 GMT
etag: 203c3b25094c8251a8ea2f427745a917

[davidberenstein1957]

This seems related #4302