Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fix error in assign_workspaces in utils module #4340

Closed
sdiazlor opened this issue Nov 28, 2023 · 1 comment · Fixed by #4341
Closed

[BUG] Fix error in assign_workspaces in utils module #4340

sdiazlor opened this issue Nov 28, 2023 · 1 comment · Fixed by #4341
Assignees
@sdiazlor
Labels
area: server Indicates that an issue or pull request is related to the server team: backend Indicates that the issue or pull request is owned by the backend team team: interns Indicates that the issue or pull request is owned by the machine learning interns team type: bug Indicates an unexpected problem or unintended behavior
Milestone
v1.20.0

Comments

@sdiazlor
Copy link
Contributor

Describe the bug
The .id was needed
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS [e.g. iOS]:
  • Browser [e.g. chrome, safari]:
  • Argilla Version [e.g. 1.0.0]:
  • ElasticSearch Version [e.g. 7.10.2]:
  • Docker Image (optional) [e.g. argilla:v1.0.0]:

Additional context
Add any other context about the problem here.
@sdiazlor sdiazlor self-assigned this Nov 28, 2023
@sdiazlor sdiazlor added the team: interns Indicates that the issue or pull request is owned by the machine learning interns team label Nov 28, 2023
@davidberenstein1957 davidberenstein1957 added this to the v1.20.0 milestone Nov 28, 2023
@sdiazlor sdiazlor mentioned this issue Nov 28, 2023
Merged
10 tasks
@sdiazlor sdiazlor linked a pull request Nov 28, 2023 that will close this issue
bug: fix bug and update test #4341
Merged
10 tasks
@dosubot dosubot bot added area: server Indicates that an issue or pull request is related to the server team: backend Indicates that the issue or pull request is owned by the backend team type: bug Indicates an unexpected problem or unintended behavior labels Nov 28, 2023
@dosubot DosuBot
Copy link

dosubot bot commented Nov 28, 2023

🤖

Hello @sdiazlor!

I'm Dosu, an AI bot here to assist you with Argilla-related issues while we wait for a human maintainer to join us. I can help you troubleshoot bugs, answer questions about our project, and guide you on how to be a valuable contributor.

Feel free to ask anything and I'll do my best to assist you.

Thank you for reporting this bug. It seems like the error is related to the assign_workspaces function in the utils module. However, without the exact error message, it's difficult to pinpoint the exact issue.

The assign_workspaces function is designed to assign workspaces to either groups or individuals, and create them if needed. It takes two arguments: assignments and workspace_type. The assignments argument is either a dictionary of groups or a dictionary of users. The workspace_type argument is a string that can be either 'group', 'group_personal', or 'individual'. The function returns a dictionary where each key is a workspace name and its value is a list of user names. You can find more details about this function in the source code.

To help us better understand the issue, could you please provide the following information:

  1. The exact error message that is being displayed when the bug occurs.
  2. The line of code that is causing the error.
  3. The steps to reproduce the error.
  4. The expected behavior of the assign_workspaces function when it is working correctly.
  5. The environment information including OS, browser, Argilla version, ElasticSearch version, and Docker Image (if applicable).

This information will help us identify the root cause of the issue and provide a solution. Thank you for your cooperation.

Sources

davidberenstein1957 pushed a commit that referenced this issue Nov 28, 2023
@sdiazlor
bug: fix bug and update test (#4341)
f131717 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

Closes #4340 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [ ] Test A
- [ ] Test B

**Checklist**

- [ ] I followed the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the `CHANGELOG.md` file (See
https://keepachangelog.com/)
davidberenstein1957 pushed a commit that referenced this issue Nov 29, 2023
@sdiazlor @davidberenstein1957
bug: fix bug and update test (#4341)
bbed3b0 
<!-- Thanks for your contribution! As part of our Community Growers
initiative 🌱, we're donating Justdiggit bunds in your name to reforest
sub-Saharan Africa. To claim your Community Growers certificate, please
contact David Berenstein in our Slack community or fill in this form
https://tally.so/r/n9XrxK once your PR has been merged. -->

# Description

Please include a summary of the changes and the related issue. Please
also include relevant motivation and context. List any dependencies that
are required for this change.

Closes #4340 

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [ ] Test A
- [ ] Test B

**Checklist**

- [ ] I followed the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the `CHANGELOG.md` file (See
https://keepachangelog.com/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdiazlor sdiazlor

Labels
area: server Indicates that an issue or pull request is related to the server team: backend Indicates that the issue or pull request is owned by the backend team team: interns Indicates that the issue or pull request is owned by the machine learning interns team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
v1.20.0
Development

Successfully merging a pull request may close this issue.

bug: fix bug and update test argilla-io/argilla
2 participants
@davidberenstein1957 @sdiazlor