feat: Unify record-level actions for all tasks (Validate, Clear, and Discard) #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithCuniah
reviewed
Feb 2, 2023
| !annotationEnabled | ||
| ? 'content--exploration-mode' | ||
| : 'content--annotation-mode', | ||
| ]" |
There was a problem hiding this comment.
separate the binded classes and the other classes =>
class="content content--separator" :class="[ !annotationEnabled ? 'content--exploration-mode' : 'content--annotation-mode', ]"
keithCuniah
reviewed
Feb 2, 2023
| let newS = { | ||
| score: 1, | ||
| text: sentence, | ||
| text: this.record.sentenceForAnnotation, |
There was a problem hiding this comment.
is sentenceForAnnotation always a properties of record ? if not, manage the undefined case
keithCuniah
reviewed
Feb 2, 2023
| }); | ||
| it("expect to show discard button active", async () => { | ||
| testIfButtonIsDisabled("discard", undefined); | ||
| }); |
There was a problem hiding this comment.
why undefined and not null ?
There was a problem hiding this comment.
The response if is not disabled is "undefined" because disabled is undefined in the wrapper attributes
keithCuniah
approved these changes
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aligns record-level actions for all tasks (Validate, Clear, and Discard) and include the new design
Closes #2266
See #2264
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist