-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Client): Add a new component for multi-label text classification bulk annotation #2291
Conversation
…tion and BulkAnnotationForm
…omponent-for-multilabel-textclassification-bulk-annotation
…ition for multilabel
One comment, in the case of a label already applied to some records, the icon of the cross and the label have different behavior. If we have 20 records selected in a page: X |
.../global-actions/text-classification-bulk-annotation/textClassificationBulkAnnotation.spec.js
Outdated
Show resolved
Hide resolved
055c9a5
to
b129028
Compare
790a164
to
cace7eb
Compare
@frascuchon your example for me is the correct behavior, we emit a reset in case of single label with empty labels (it's not new behavior and we can discuss). I see some things that don't fit, there is supposed to be no pending status in the single Text Classifier Classifier, so for me the "clear" button doesn't make sense for this case. I will comment in specs. |
…-bulk-annotation' of https://github.com/recognai/rubrix into feature/new-component-for-multilabel-textclassification-bulk-annotation
# Description Add feedback on discard/validation for bulk annotation. This concerned the 3 tasks ref #2291 **Type of change** - [x] New feature (non-breaking change which adds functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [x] TextClassification (single and multilabel) - [x] TokenClassification - [x] Text2Text **Checklist** - [ ] I have merged the original branch into my forked branch - N/A I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - N/A I added comments to my code - [N/A I made corresponding changes to the documentation - [x] My changes generate no new warnings - N/A I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: keithCuniah <[email protected]>
Description
Components :
Note :
remove
attribute from the form since we can guess which annotation will be remove only with theselected
attribute, I will update the docWhat is left :
Closes #2267
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist