Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove the classification labeling rules service #2361

Merged
merged 8 commits into from
Feb 20, 2023

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Feb 17, 2023

Description

This PR move the labeling rule operations from the labeling rule service to the text-classfication service.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

Checklist

  • I have merged the original branch into my forked branch
  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I added comments to my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 91.86% // Head: 91.85% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (faa225b) compared to base (4c5f513).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2361      +/-   ##
===========================================
- Coverage    91.86%   91.85%   -0.01%     
===========================================
  Files          161      160       -1     
  Lines         7869     7849      -20     
===========================================
- Hits          7229     7210      -19     
+ Misses         640      639       -1     
Flag Coverage Δ
pytest 91.85% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ver/services/tasks/text_classification/__init__.py 100.00% <ø> (ø)
...rver/services/tasks/text_classification/metrics.py 98.33% <ø> (ø)
src/argilla/server/apis/v0/handlers/metrics.py 97.50% <100.00%> (+0.27%) ⬆️
...lla/server/apis/v0/handlers/text_classification.py 86.53% <100.00%> (ø)
src/argilla/server/daos/backend/metrics/base.py 100.00% <100.00%> (ø)
...server/daos/backend/metrics/text_classification.py 98.18% <100.00%> (ø)
src/argilla/server/services/datasets.py 97.27% <100.00%> (+0.05%) ⬆️
src/argilla/server/services/metrics/service.py 100.00% <100.00%> (ø)
...server/services/tasks/text_classification/model.py 99.35% <100.00%> (+0.04%) ⬆️
...rver/services/tasks/text_classification/service.py 96.46% <100.00%> (+0.90%) ⬆️
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jfcalvo jfcalvo merged commit 175a52a into develop Feb 20, 2023
@jfcalvo jfcalvo deleted the refactor-classification-labeling-rules branch February 20, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants