feat: manage pending status when updating #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithCuniah
reviewed
Mar 3, 2023
| class="primary small toast__button" | ||
| @click="whenClicked" | ||
| >{{ buttonText }}</base-button | ||
| > |
There was a problem hiding this comment.
1/ review formatting
2/ naming : change whenClicked by onClick
keithCuniah
reviewed
Mar 3, 2023
| const arePendingRecords = records.some( | ||
| (record) => record.status === "Edited" | ||
| ); | ||
| await _updateViewSettings({ |
There was a problem hiding this comment.
naming => change _myFunction by myFunction
keithCuniah
reviewed
Mar 3, 2023
| @@ -479,6 +486,22 @@ async function _updatePagination({ id, size, page }) { | |||
| return pagination; | |||
| } | |||
|
|
|||
| async function _chooseContinueOrCancel(action, dataset, query, sort, size) { | |||
There was a problem hiding this comment.
naming => change _myFunction by myFunction
keithCuniah
reviewed
Mar 3, 2023
| }); | ||
| }, | ||
| }); | ||
| } |
There was a problem hiding this comment.
code cleanning : one thing by line => create the object before the call for notification toast
keithCuniah
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PT includes notification to manage pending status when updating
Closes #<issue_number>
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
Checklist