Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate datasets crud endpoints #2510

Merged

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Mar 9, 2023

This PR integrates new DB logic and policies with the current implementation.

  • The main changes are applied to the dataset service class
  • The auth.get_current_user returns a models.User instance
  • The ONLY change in endpoints is using this new auth.get_current_user method

In a separate PR the pydantic User class will be cleaned and normalized

@frascuchon frascuchon changed the base branch from develop to feat/add-basic-database-support March 9, 2023 08:26
@frascuchon frascuchon requested a review from jfcalvo March 10, 2023 16:20
@frascuchon frascuchon marked this pull request as ready for review March 10, 2023 16:22
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 90.38% and project coverage change: +0.80 🎉

Comparison is base (8c05058) 92.74% compared to head (165852c) 93.54%.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           feat/add-basic-database-support    #2510      +/-   ##
===================================================================
+ Coverage                            92.74%   93.54%   +0.80%     
===================================================================
  Files                                  167      163       -4     
  Lines                                 8271     8217      -54     
===================================================================
+ Hits                                  7671     7687      +16     
+ Misses                                 600      530      -70     
Flag Coverage Δ
pytest 93.54% <90.38%> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/argilla/client/api.py 95.34% <ø> (ø)
src/argilla/client/sdk/text_classification/api.py 100.00% <ø> (+12.90%) ⬆️
src/argilla/server/apis/v0/handlers/metrics.py 97.50% <ø> (ø)
src/argilla/server/apis/v0/handlers/records.py 100.00% <ø> (ø)
.../argilla/server/apis/v0/handlers/records_update.py 100.00% <ø> (ø)
...rc/argilla/server/daos/backend/mappings/helpers.py 97.22% <ø> (ø)
src/argilla/tasks/users/migrate.py 100.00% <ø> (ø)
src/argilla/client/apis/datasets.py 92.62% <78.57%> (-4.58%) ⬇️
src/argilla/server/services/datasets.py 90.35% <82.45%> (-5.53%) ⬇️
src/argilla/client/client.py 93.07% <84.61%> (+6.25%) ⬆️
... and 26 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon requested a review from jfcalvo March 11, 2023 10:03
@frascuchon frascuchon merged commit 83a11e9 into feat/add-basic-database-support Mar 13, 2023
@frascuchon frascuchon deleted the integrate-datasets-CRUD-endpoints branch March 13, 2023 09:04
@frascuchon frascuchon restored the integrate-datasets-CRUD-endpoints branch March 15, 2023 17:18
@damianpumar damianpumar deleted the integrate-datasets-CRUD-endpoints branch April 22, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants