Support api-key and password as parameter when using users.create_default task #2516
Conversation
…iables to be used when creating default user
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/add-basic-database-support #2516 +/- ##
===================================================================
+ Coverage 92.74% 93.58% +0.83%
===================================================================
Files 167 163 -4
Lines 8271 8195 -76
===================================================================
- Hits 7671 7669 -2
+ Misses 600 526 -74
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| @@ -30,17 +31,17 @@ def create_default(quiet: bool): | |||
| first_name="", | |||
| username=DEFAULT_USERNAME, | |||
| role=UserRole.admin, | |||
| api_key=DEFAULT_API_KEY, | |||
| password_hash=accounts.hash_password(DEFAULT_PASSWORD), | |||
| api_key=settings.api_key, | |||
There was a problem hiding this comment.
If these settings are used only for the argilla task, I would prefer using a click.option instead, and calling the tasks:
python -m argilla.tasks.users.create_default --password $MY_PASS --api-key $MY_API_KEYFor me, it's a bit weird having app env vars used only on this task.
There was a problem hiding this comment.
I agree but then users.create_default is useless because we already have users.create (and it will have the possibility of setting the api key, that is necessary for the team user of the QuickStart docker image).
There was a problem hiding this comment.
I Agree. Also, in docs we can just say:
"Create the default user by typing:
argilla users create --username argilla --password 1234 --api-key argilla.apiKey --role adminEDIT
Indeed is not possible since the password constraints. And I would like to keep this constraints for the common user creation command
…ated default username before create it
jfcalvo
changed the title
This PR includes the following changes:
--api-keyand--passwordparameters toargilla.tasks.users.create_default.argilla.tasks.users.create_defaultchecks if there is a user using default username before creating it and showing a message in such case (but not raising an error).