Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused superuser attribute #2600

Merged

Conversation

frascuchon
Copy link
Member

This PR just removes the unused superuser attribute in User pydantic class

@frascuchon frascuchon requested a review from jfcalvo March 24, 2023 12:07
@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage: 92.38% and project coverage change: +0.78 🎉

Comparison is base (8c05058) 92.74% compared to head (0a2f8be) 93.53%.

Additional details and impacted files
@@                         Coverage Diff                         @@
##           feat/add-basic-database-support    #2600      +/-   ##
===================================================================
+ Coverage                            92.74%   93.53%   +0.78%     
===================================================================
  Files                                  167      164       -3     
  Lines                                 8271     8272       +1     
===================================================================
+ Hits                                  7671     7737      +66     
+ Misses                                 600      535      -65     
Flag Coverage Δ
pytest 93.53% <92.38%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/argilla/client/api.py 95.34% <ø> (ø)
src/argilla/client/sdk/text_classification/api.py 100.00% <ø> (+12.90%) ⬆️
...rc/argilla/server/daos/backend/mappings/helpers.py 97.22% <ø> (ø)
src/argilla/server/server.py 87.93% <ø> (+0.43%) ⬆️
src/argilla/server/services/datasets.py 92.37% <ø> (-3.51%) ⬇️
src/argilla/server/services/metrics/service.py 100.00% <ø> (ø)
src/argilla/server/services/storage/service.py 100.00% <ø> (ø)
src/argilla/server/settings.py 80.95% <ø> (ø)
src/argilla/tasks/users/create.py 100.00% <ø> (ø)
src/argilla/tasks/users/create_default.py 100.00% <ø> (ø)
... and 36 more

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit f042c2f into feat/add-basic-database-support Mar 24, 2023
@frascuchon frascuchon deleted the remove-superuser-attribute branch March 24, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants