feat: add multi label selection question to the API #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) # Description This PR adds a param `use_markdown` to the `TextFieldSettings` and `TextQuestionSettings` classes in API to enable markdown support. By default, the parameter is disabled, which is compatible with the previous behavior. Also, some tests creating dataset fields and questions have been grouped using the `pytest.mark.parameterize` decorator, since the internal behavior was the same. Refs #2998 **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [x] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** New tests have been created **Checklist** - [x] I have merged the original branch into my forked branch - [ ] I added relevant documentation - [x] follows the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [x] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: gabrielmbmb <[email protected]>
`QuestionCreate`
Co-authored-by: Francisco Aranda <[email protected]>
gabrielmbmb
added
type: enhancement
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3010 +/- ##
========================================
Coverage 92.92% 92.93%
========================================
Files 204 204
Lines 10820 10833 +13
========================================
+ Hits 10055 10068 +13
Misses 765 765
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
frascuchon
reviewed
May 29, 2023
frascuchon
reviewed
May 29, 2023
10 tasks
alvarobartt
added a commit
that referenced
this pull request
Jun 8, 2023
…3100) # Description This PR adds support to the recently included `LabelSelectionQuestion` and `MultiLabelSelectionQuestion` new types of questions as of #3005 and #3010, respectively, in the Python client side. Closes #3099 **Type of change** - [X] New feature (non-breaking change which adds functionality) **How Has This Been Tested** - [x] Add integration tests for the recently included questions **Checklist** - [X] I have merged the original branch into my forked branch - [X] I added relevant documentation - [X] follows the style guidelines of this project - [X] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [X] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added the required class
MultiLabelSelectionQuestionSettingsto create the new type of question multi-label selection question (also known as a multi-choice question) and to validate the responses submitted for this kind of question.Also, I've removed the parametrization of the
test_create_record_response_with_extra_question_responsesunit test that I'd added in #3005 accidentally because I thought the validation of this depended on the question itself.Closes #2996
Type of change
How Has This Been Tested
I've created some unit tests to test the creation of this new type of question and also to validate the responses submitted to it.
Checklist