feat: improve protected fields #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3342 +/- ##
===========================================
+ Coverage 90.13% 90.46% +0.32%
===========================================
Files 233 239 +6
Lines 12493 12837 +344
===========================================
+ Hits 11261 11613 +352
+ Misses 1232 1224 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
gabrielmbmb
approved these changes
Jul 5, 2023
davidberenstein1957
approved these changes
Jul 5, 2023
| @@ -22,9 +22,12 @@ | |||
| DEFAULT_MAX_KEYWORD_LENGTH = 128 | |||
| DEFAULT_TELEMETRY_KEY = "C6FkcaoCbt78rACAgvyBxGBcMB3dM3nn" | |||
|
|
|||
| # The metadata field name prefix defined for protected (non-searchable) values | |||
| PROTECTED_METADATA_FIELD_PREFIX = "_" | |||
There was a problem hiding this comment.
Can we add this to the documentation somewhere?
Co-authored-by: Gabriel Martín Blázquez <[email protected]> Co-authored-by: David Berenstein <[email protected]>
leiyre
pushed a commit
that referenced
this pull request
Jul 6, 2023
* develop: feat: disable concurrency tests GitHub (#3355) feat: improve protected fields (#3342) chore: added telemetry to ArgillaTrainer (#3336) Feat/update start page code (#3327) [DOCS] Added information about tests in developer documentation (#3147) # Conflicts: # docs/_source/_common/snippets/start_page.md # frontend/components/commons/datasets-list/DatasetsEmpty.vue
leiyre
pushed a commit
that referenced
this pull request
Jul 6, 2023
* develop: feat: disable concurrency tests GitHub (#3355) feat: improve protected fields (#3342) chore: added telemetry to ArgillaTrainer (#3336) Feat/update start page code (#3327) [DOCS] Added information about tests in developer documentation (#3147) # Conflicts: # docs/_source/_common/snippets/start_page.md # frontend/components/commons/datasets-list/DatasetsEmpty.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reviews and improves the protected metadata field's functionality:
Closes #3331
Closes #3332
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)tested with a local instance
Checklist