Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing suggestion_type_enum values #3445

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: add missing suggestion_type_enum values #3445

merged 2 commits into from
Jul 24, 2023

Conversation

gabrielmbmb
Copy link
Member

Description

This PR add a new migration that adds the missing values for the suggestion_type_enum ENUM type created in PostgreSQL.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Applying the migrations locally to a PostgreSQL deployed with Docker.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb added type: bug Indicates an unexpected problem or unintended behavior area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints labels Jul 24, 2023
@frascuchon frascuchon merged commit ac6bc40 into releases/1.13.2 Jul 24, 2023
@frascuchon frascuchon deleted the fix/suggestion-type-enum-values branch July 24, 2023 13:04
leiyre pushed a commit that referenced this pull request Aug 1, 2023
Merge branch 'feat/shortcuts-improvements' of github.com:argilla-io/a…
c942251 
…rgilla into feat/shortcuts-improvements

* 'feat/shortcuts-improvements' of github.com:argilla-io/argilla:
  feat: update CLI to use async connection to DB (#3450)
  feat: add more value validations for rating questions (#3452)
  ci: selective `runs-on` value for tests execution (#3455)
  feat: update `package.yml` triggers (#3422)
  fix: uncancellable CI jobs (#3458)
  chore: Fix `ruff` line length (#3459)
  [pre-commit.ci] pre-commit autoupdate (#3449)
  improvement: Better efficiency of Weak Labels when vectors exist (#3444)
  refactor: add `ArgillaDatasetMixin` and re-structure `argilla.feedback.schemas` (#3427)
  chore: Set release version
  fix: add missing `suggestion_type_enum` values (#3445)
  [pre-commit.ci] pre-commit autoupdate (#3380)
  docs: fix username in HF Spaces docs (#3432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frascuchon frascuchon frascuchon approved these changes

Assignees
No one assigned
Labels
area: api Indicates that an issue or pull request is related to the Fast API server or REST endpoints type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrielmbmb @frascuchon