Return str for TrainingTaskMappingForTextClassification.__repr__
#3574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3574 +/- ##
===========================================
+ Coverage 90.42% 90.63% +0.21%
===========================================
Files 255 255
Lines 13530 13538 +8
===========================================
+ Hits 12234 12270 +36
+ Misses 1296 1268 -28
☔ View full report in Codecov by Sentry. |
davidberenstein1957
approved these changes
Aug 16, 2023
artikandri
pushed a commit
to CLARIN-PL/argilla
that referenced
this pull request
Oct 30, 2023
…rgilla-io#3574) # Description This PR returns `str` for `TrainingTaskMappingForTextClassification.__repr__`. I assumed the expected return was what the method already contained without the commas. Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. Closes argilla-io#3573 **Type of change** - [x] Bug fix (non-breaking change which fixes an issue) **How Has This Been Tested** Basic test under `test/unit/client/feedback/training/test_schema.py` to check the return from the `__repr__` method is a `str`. **Checklist** - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [ ] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR returns
strforTrainingTaskMappingForTextClassification.__repr__. I assumed the expected return was what the method already contained without the commas.Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Closes #3573
Type of change
How Has This Been Tested
Basic test under
test/unit/client/feedback/training/test_schema.pyto check the return from the__repr__method is astr.Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)