Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add allowed_for_roles to manage RemoteFeedbackDataset permissions #3601

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

alvarobartt
Copy link
Member

Description

This PR adds allowed_for_roles for RemoteFeedbackDataset, RemoteFeedbackRecords, and RemoteFeedbackRecord when needed, as the annotator cannot do most of the operations.

Since the RemoteFeedbackDataset, RemoteFeedbackRecords, and RemoteFeedbackRecord are just intended to be used from either an owner or an admin, we should probably restrict everything to those roles only.

Closes #3545

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

  • Add integration tests to check role in methods decorated with allowed_for_roles
  • Add missing await before RecordFactory

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt added this to the 1.15.0 milestone Aug 21, 2023
@alvarobartt alvarobartt self-assigned this Aug 21, 2023
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3601-ki24f765kq-no.a.run.app

@alvarobartt alvarobartt merged commit aeb5b8e into develop Aug 22, 2023
15 checks passed
@alvarobartt alvarobartt deleted the fix/revisit-permissions branch August 22, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Revisit permissions in FeedbackDataset via allowed_for_roles
2 participants