fix: add allowed_for_roles
to manage RemoteFeedbackDataset
permissions
#3601
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
allowed_for_roles
forRemoteFeedbackDataset
,RemoteFeedbackRecords
, andRemoteFeedbackRecord
when needed, as theannotator
cannot do most of the operations.Since the
RemoteFeedbackDataset
,RemoteFeedbackRecords
, andRemoteFeedbackRecord
are just intended to be used from either anowner
or anadmin
, we should probably restrict everything to those roles only.Closes #3545
Type of change
How Has This Been Tested
role
in methods decorated withallowed_for_roles
await
beforeRecordFactory
Checklist