Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TaskType.multi_task_text_token_classification #3640

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Aug 28, 2023

Description

This PR removes the multi_task_text_token_classification from the TaskType enum from both the client and the server, as it's unused, and can lead to confusion.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • No need to, as TaskType.multi_task_text_token_classification was not being covered by tests

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt added this to the v1.15.0 milestone Aug 28, 2023
@alvarobartt alvarobartt self-assigned this Aug 28, 2023
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3640-ki24f765kq-no.a.run.app

Copy link
Member

@frascuchon frascuchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if this is something useless, it would be nice to track the change in the CHANGELOG.md inside the Removed section

@alvarobartt alvarobartt merged commit ed8c6fb into develop Aug 28, 2023
11 checks passed
@alvarobartt alvarobartt deleted the fix/remove-unused-task-type branch August 28, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants