Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add datasets list command #3658

Merged
merged 9 commits into from
Aug 30, 2023
Merged

Conversation

gabrielmbmb
Copy link
Member

Description

This PR adds a new command python -m argilla datasets list which allows to list the datasets from the logged Argilla server in the terminal.

image

Closes #3591

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

I've created a custom environment, used the python -m argilla login command to login in it and then list the datasets from this environment using the new command. All the datasets were listed. Applying workspace filter worked. Applying dataset kind filter worked. Additionally, I've added unit tests to cover all the additions.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@gabrielmbmb gabrielmbmb added type: enhancement Indicates new feature requests client labels Aug 29, 2023
@gabrielmbmb gabrielmbmb added this to the v1.16.0 milestone Aug 29, 2023
@gabrielmbmb gabrielmbmb self-assigned this Aug 29, 2023
@alvarobartt
Copy link
Member

cc @gabrielmbmb make sure to change the base from develop to releases/1.15.0 if you want to add this CLI feature in the current release!

@gabrielmbmb
Copy link
Member Author

@alvarobartt thanks! but these commands will get finally included in 1.16.0

@codecov
Copy link

codecov bot commented Aug 29, 2023

@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3658-ki24f765kq-no.a.run.app

Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Most of the comments are about the rename from kind and DatasetKind to dataset_type and DatasetType.

CHANGELOG.md Show resolved Hide resolved
src/argilla/tasks/datasets/list.py Outdated Show resolved Hide resolved
src/argilla/tasks/datasets/list.py Outdated Show resolved Hide resolved
src/argilla/tasks/datasets/list.py Outdated Show resolved Hide resolved
src/argilla/tasks/datasets/list.py Outdated Show resolved Hide resolved
src/argilla/tasks/datasets/list.py Outdated Show resolved Hide resolved
tests/unit/tasks/datasets/test_list.py Outdated Show resolved Hide resolved
tests/unit/tasks/datasets/test_list.py Outdated Show resolved Hide resolved
tests/unit/tasks/datasets/test_list.py Outdated Show resolved Hide resolved
tests/unit/tasks/datasets/test_list.py Outdated Show resolved Hide resolved
@gabrielmbmb gabrielmbmb force-pushed the feature/cli-list-datasets-command branch from 69e0b43 to ddd7a86 Compare August 30, 2023 10:57
@gabrielmbmb gabrielmbmb force-pushed the feature/cli-list-datasets-command branch from ddd7a86 to 276eac9 Compare August 30, 2023 10:58
@gabrielmbmb gabrielmbmb force-pushed the feature/cli-list-datasets-command branch from 8932816 to 08d1975 Compare August 30, 2023 11:02
@gabrielmbmb gabrielmbmb force-pushed the feature/cli-list-datasets-command branch from f70d116 to bfb81ae Compare August 30, 2023 11:20
@gabrielmbmb gabrielmbmb merged commit 3c9b5d0 into develop Aug 30, 2023
17 checks passed
@gabrielmbmb gabrielmbmb deleted the feature/cli-list-datasets-command branch August 30, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add list datasets command python -m argilla datasets list
2 participants